Re: Don't choke on files that are removed while pg_rewind runs. - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Don't choke on files that are removed while pg_rewind runs.
Date
Msg-id 2D8BDE8C-1407-4516-841E-0E502555A901@yesql.se
Whole thread Raw
In response to Re: Don't choke on files that are removed while pg_rewind runs.  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Don't choke on files that are removed while pg_rewind runs.  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
> On 13 Jul 2020, at 14:18, Michael Paquier <michael@paquier.xyz> wrote:

> That sounds like a good idea with an extra qual in the first part of
> the inner CTE, if coupled with a check to make sure that we never
> get a NULL result.  Now there is IMO an argument to not complicate
> more this query as it is not like a lot of tuples would get filtered
> out anyway because of a NULL set of values?  I don't have strong
> feelings for one approach or the other, but if I were to choose, I
> would just let the code as-is, without the change in the CTE.

I don't have strong opinions either, both approaches will work, so feel free to
go ahead with the proposed change.

cheers ./daniel


pgsql-hackers by date:

Previous
From: Atsushi Torikoshi
Date:
Subject: Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
Next
From: Jochem van Dieten
Date:
Subject: Re: recovering from "found xmin ... from before relfrozenxid ..."