Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c - Mailing list pgsql-hackers

From Chris Campbell
Subject Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c
Date
Msg-id 2D06E628-77EC-46B7-933D-CFCBDD800645@bignerdranch.com
Whole thread Raw
In response to Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c  (Bruce Momjian <bruce@momjian.us>)
Bonjour patch  (Bruce Momjian <bruce@momjian.us>)
Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Oct 8, 2006, at 14:29, Tom Lane wrote:

> Looks good, but I don't think we want to abandon OSX 10.2 support
> just yet.  I'll revise this to use a configure probe for dlopen.

Maybe we can abandon Mac OS X 10.2 in 8.3 and later? And not back- 
port these patches to the 7.x, 8.0, and 8.1 branches?

BTW, I think the configure probe (only on Darwin, correct?) should  
test for the existence of <dlfcn.h>.

> My inclination is to apply this one now, since it only affects OSX
> and should be easily testable, but to hold off on your other patch
> for portable Bonjour support until 8.3 devel starts.  The portability
> implications of that one are unclear, and I don't know how to test it
> either, so I think putting it in now is too much risk.

The Bonjour patch wasn't intended to be portable to other platforms  
just yet. As submitted, it has the same risks/advantages as this  
dlopen() patch -- it only works on 10.3 and later, but isn't  
deprecated in 10.4.

If we want to keep 10.2 support for Bonjour, we can test for both  
DNSServiceDiscovery.h and dns_sd.h in ./configure, and prefer  
dns_sd.h if it's found (which will be the case for 10.3 and 10.4) but  
use DNSServiceDiscovery.h if not (which will be the case for 10.2).

Thanks!

- Chris



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Add include needed for new getrusage() call.
Next
From: "Joshua D. Drake"
Date:
Subject: Re: The improvement for psql of 8.2beta1 not