Re: Move wal_buffers_full to WalUsage (and report it in pgss/explain) - Mailing list pgsql-hackers

From Ilia Evdokimov
Subject Re: Move wal_buffers_full to WalUsage (and report it in pgss/explain)
Date
Msg-id 298b59c9-ae18-41d4-a426-189c5a13b907@tantorlabs.com
Whole thread Raw
Responses Re: Move wal_buffers_full to WalUsage (and report it in pgss/explain)
List pgsql-hackers
Hi,

Thank you for your work!

1. Perhaps In EXPLAIN you forget to check that usage->wal_buffers_full > 0:

if ((usage->wal_records > 0) || (usage->wal_fpi > 0) || 
(usage->wal_bytes > 0))


2. I have a small suggestion for pg_stat_statements: would it make sense 
to move wal_buffers_full next to wal_records, wal_fpi and wal_bytes? 
This way, all WAL-related information would be grouped together.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.




pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: pg_stat_statements and "IN" conditions
Next
From: Álvaro Herrera
Date:
Subject: Re: NOT ENFORCED constraint feature