Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE' - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
Date
Msg-id 29797.1566572294@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclaredidentifier 'FD_SETSIZE'  (Michael Paquier <michael@paquier.xyz>)
Responses Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclaredidentifier 'FD_SETSIZE'
List pgsql-bugs
Michael Paquier <michael@paquier.xyz> writes:
> The latest patch does that:
> +    pg_log_fatal("too many jobs for this platform's select() -- try %d"
> Do you have a better suggestion to offer, like a s#jobs#-j/--jobs#?

That seems over-punctuated, plus it burdens the reader with unnecessary
detail.  Most SQL folk would be confused by the reference to SELECT,
I bet.  (In fact, don't we have a style guideline against mentioning
particular syscalls?)

How about just "too many jobs for this platform -- try %d" ?

            regards, tom lane



pgsql-bugs by date:

Previous
From: PG Bug reporting form
Date:
Subject: BUG #15974: Concact with || doesn't work, but function CONCAT () works
Next
From: Merlin Moncure
Date:
Subject: data modifying WITH seems to drop rows in cascading updates -- bug?