Re: [HACKERS] [ADMIN] invalid multibyte character for locale - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] [ADMIN] invalid multibyte character for locale
Date
Msg-id 2963.1110865923@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] [ADMIN] invalid multibyte character for locale  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> Perhaps it would be reasonable to do something like this:
>>
>> #ifdef USE_WIDE_UPPER_LOWER
>> /*
>> * use wide char code only when max encoding length > one
>> * and we aren't in C locale
>> */
>> if (pg_database_encoding_max_length() > 1 &&
>> !lc_ctype_is_c())

> Tom, is this the fix you were thinking of?  Seems like it would be a
> good improvement.

Please fix the comments not only the code ;-).  Other than that,
this is exactly what I meant.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] [ADMIN] invalid multibyte character for locale
Next
From: "Magnus Hagander"
Date:
Subject: Kerberos code overwrites it's own error message