Hi Neil,
I also saw an mm_alloc or something similar in another area of code.
I'll spend some time reading through the sources properly before I
attempt another mod. Thanks for the feedback -- much appreciated.
/s.
On Feb 10, 2004, at 3:24 PM, Neil Conway wrote:
> Scott Goodwin <scott@scottg.net> writes:
>> If anyone cares to, I'd still like feedback on anything I could have
>> done better in this patch
>
> Since, you asked, two minor points: (1) palloc() is for memory
> allocation in the backend; use malloc() (or a wrapper like
> pg_malloc()) in frontend apps and libpq (2) naming variables like
> word1_Word2 is inconsistent with the surrounding code.
>
> -Neil
>