Re: SPI: Correct way to rollback a subtransaction? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: SPI: Correct way to rollback a subtransaction?
Date
Msg-id 29559.1140477600@sss.pgh.pa.us
Whole thread Raw
In response to Re: SPI: Correct way to rollback a subtransaction?  ("Marko Kreen" <markokr@gmail.com>)
Responses Re: SPI: Correct way to rollback a subtransaction?
List pgsql-hackers
"Marko Kreen" <markokr@gmail.com> writes:
> On 2/20/06, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> This seems like a pretty bad idea: if the SPI_connect fails you lose
>> control without having unwound the subtransaction.  That's unlikely,
>> but still wrong.

> But if I want the error to reach upper transaction?  SPI_connect
> failure does not seem a 'expected' situation to me.

In that case you should put the SPI_connect and later SPI_finish
*outside* the subtransaction and TRY block.  And you'll need
SPI_restore_connection I think.  This structure would be exactly
parallel to the way pl_exec.c does it.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: dropped columns, tupDesc
Next
From: "Sergey E. Koposov"
Date:
Subject: Re: dropped columns, tupDesc