Re: using index or check in ALTER TABLE SET NOT NULL - Mailing list pgsql-hackers

From Sergei Kornilov
Subject Re: using index or check in ALTER TABLE SET NOT NULL
Date
Msg-id 2947361520607085@web26g.yandex.ru
Whole thread Raw
In response to Re: using index or check in ALTER TABLE SET NOT NULL  (Ildar Musin <i.musin@postgrespro.ru>)
Responses Re: using index or check in ALTER TABLE SET NOT NULL  (Sergei Kornilov <sk@zsrv.org>)
List pgsql-hackers
Hello all!
Summarizing, how i must update tests?
We want test real skip of verify phase or only result correctness?

I can verify what i do not break alter table by tests in v4 of my patch. But here is no check code path. So my feature
maybe broken in future without test fail. alter table will be correct regardless this feature.
 
Or i must test code path too? I understood Tom and will remove INFO ereport from patch anyway. But currently i have no
ideahow check code path. As mentioned earlier using debug ereport is uncomfortable too. Here is no suitable event
triggerto track what exactly happens with table. Adding new one for test purposes seems overkill.
 

regards, Sergei


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Testbed for predtest.c ... and some arguable bugs therein
Next
From: Pavan Deolasee
Date:
Subject: Re: [HACKERS] MERGE SQL Statement for PG11