Re: Bug in numeric multiplication - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Bug in numeric multiplication
Date
Msg-id 29374.1447771383@sss.pgh.pa.us
Whole thread Raw
In response to Re: Bug in numeric multiplication  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: Bug in numeric multiplication  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-hackers
Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> I just noticed that div_var_fast() has almost identical code, and so
> in principle it has the same vulnerability, although it obviously only
> affects the transcendental functions.
> I don't actually have a test case that triggers it, but it's basically
> the same algorithm, so logically it needs the same additional headroom
> to avoid a possible overflow.

Hm, good point.  I don't feel a compulsion to have a test case that
proves it's broken before we fix it.  Do you want to send a patch?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: [PATCH] better systemd integration
Next
From: Jim Nasby
Date:
Subject: Re: Extracting fields from 'infinity'::TIMESTAMP[TZ]