Re: SIGPIPE handling - Mailing list pgsql-patches

From Tom Lane
Subject Re: SIGPIPE handling
Date
Msg-id 29350.1069007424@sss.pgh.pa.us
Whole thread Raw
In response to Re: SIGPIPE handling  (Manfred Spraul <manfred@colorfullife.com>)
List pgsql-patches
Manfred Spraul <manfred@colorfullife.com> writes:
> + extern void PQsetsighandling(int internal_sigign);

These sorts of things are commonly designed so that the set() operation
incidentally returns the previous setting.  I'm not sure if anyone would
care, but it's only a couple more lines of code to make that happen, so
I'd suggest doing so just in case.

Otherwise I think this is a good patch.  The documentation could use a
little more wordsmithing, perhaps.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: SRA Win32 sync() code
Next
From: Jan Wieck
Date:
Subject: Re: SRA Win32 sync() code