Re: readline selection (was Re: [GENERAL] psql leaking? - SOLVED) - Mailing list pgsql-bugs

From Tom Lane
Subject Re: readline selection (was Re: [GENERAL] psql leaking? - SOLVED)
Date
Msg-id 29334.1094402673@sss.pgh.pa.us
Whole thread Raw
In response to Re: readline selection (was Re: [GENERAL] psql leaking? - SOLVED)  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-bugs
Peter Eisentraut <peter_e@gmx.net> writes:
> Tom Lane wrote:
>> (2) fix the readline header selection so that it will only take the
>> headers that correspond to the selected library.

> That sounds like a pretty hard problem to solve.

It didn't seem that bad to me.  One problem is to not select, eg,
<readline/readline.h> in preference to <editline/readline.h> if we've
selected libedit for linking to.  (I think that is the behavior that
bit Russ.)  But that seems a small matter of paying attention to a flag
variable set by PGAC_CHECK_READLINE.  The other problem is that if we
select <readline.h> we can't really be sure it matches the selected
library.  I'm not sure that we *need* to solve that --- if you have
readline.so and not <readline/readline.h> then <readline.h> had better
be the right thing.  But I would think it could be done with some
appropriate AC_EGREP_HEADER check if you wanted to be paranoid.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Ivan-Sun1@mail.ru
Date:
Subject: plpgsql error handling bug
Next
From: Tom Lane
Date:
Subject: Re: Permissions problem with sequences