Andrew Dunstan <andrew@dunslane.net> writes:
> On 10/02/2016 09:50 AM, Michael Paquier wrote:
>> On Sun, Oct 2, 2016 at 10:40 PM, Andrew Dunstan <andrew@dunslane.net> wrote:
>>> It looks like we have some work to do to teach pg_dump about handling access
>>> methods in extensions. This doesn't look quite as bad as the first issue,
>>> but it's a pity 9.6 escaped into the wild with this issue.
>> 562f06f3 has addressed this issue 3 months ago, and there is a test in
>> src/test/modules/test_pg_dump.
> So then why are the pre-upgrade and post-upgrade dumps different?
Because pg_dump with --binary-upgrade neglects to emit
ALTER EXTENSION bloom ADD ACCESS METHOD bloom;
which it would need to do in order to make this work right. The other
small problem is that there is no such ALTER EXTENSION syntax in the
backend. This is a rather major oversight in the patch that added DDL
support for access methods, if you ask me.
(Also, I didn't look at what test_pg_dump is testing, but I bet it
isn't attempting to cover --binary-upgrade behavior.)
regards, tom lane
