Re: Use of $(THREAD_CFLAGS) in CPPFLAGS - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Use of $(THREAD_CFLAGS) in CPPFLAGS
Date
Msg-id 293.1064630917@sss.pgh.pa.us
Whole thread Raw
In response to Use of $(THREAD_CFLAGS) in CPPFLAGS  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Use of $(THREAD_CFLAGS) in CPPFLAGS  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> I just noticed that libpq/ecpg use $(THREAD_CFLAGS) as part of CPPFLAGS.
> Is that correct?  Should it be added to CFLAGS instead?

I was just noticing that today.  THREAD_CFLAGS typically includes -D
flags, and as such it *must* be added to CPPFLAGS --- it'd be incorrect
to add it to CFLAGS.  Possibly we should rename THREAD_CFLAGS to 
THREAD_CPPFLAGS.  I'm not sure that we have any platforms for which it
would be useful to invent both THREAD_CPPFLAGS and THREAD_CFLAGS.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Separate shared_buffer management process
Next
From: Kevin Brown
Date:
Subject: Re: invalid tid errors in latest 7.3.4 stable.