Re: [PATCH] Add tests for psql tab completion - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Add tests for psql tab completion
Date
Msg-id 2920743.1644868864@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] Add tests for psql tab completion  (Matheus Alcantara <mths.dev@pm.me>)
List pgsql-hackers
Matheus Alcantara <mths.dev@pm.me> writes:
> I'm attaching a patch that add some new test cases for tab completion of psql.

What exactly is the motivation for these particular tests?

I believe that most of tab-complete.c is already covered, outside
of the giant if-else chain at the heart of psql_completion().
It's hard to summon interest in trying to cover every branch of
that chain; but if we're to add coverage of just a few more,
which ones and why?  The ones you've chosen to hit in this
patch don't seem especially interesting.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Time to drop plpython2?
Next
From: Robert Haas
Date:
Subject: Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints