Re: pgsql: Introduce WaitEventSet API. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Introduce WaitEventSet API.
Date
Msg-id 29187.1458587962@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Introduce WaitEventSet API.  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> Introduce WaitEventSet API.

Buildfarm member gaur has a quibble with this patch:

latch.c:1095: warning: `WaitEventSetWaitBlock' declared inline after being called

Please rearrange the file so that the inline function definitions appear
first.  Also, why is it that only three of the four variants are marked
"inline"?

Actually ... given that it's static and called in exactly one place,
I would think that any compiler capable of inlining it would do so
whether asked to or not.  So another solution is just to get rid
of all the "inline" specifiers and let the compiler do its job.

            regards, tom lane


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Clean up some Coverity complaints about commit 0bf3ae88af330496.
Next
From: Tom Lane
Date:
Subject: pgsql: Allow the delay in psql's \watch command to be a fractional seco