Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
Date
Msg-id 28FCD9E5-795E-44F4-ADFA-DBCAC1945DA1@enterprisedb.com
Whole thread Raw
In response to Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.  (Pavel Borisov <pashkin.elfe@gmail.com>)
Responses Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
List pgsql-hackers

> On May 17, 2024, at 11:51 AM, Pavel Borisov <pashkin.elfe@gmail.com> wrote:
>
> Amcheck with checkunique option does check uniqueness violation between pages. But it doesn't warranty detection of
crosspage uniqueness violations in extremely rare cases when the first equal index entry on the next page corresponds
totuple that is not visible (e.g. dead). In this, I followed the Peter's notion [1] that checking across a number of
deadequal entries that could theoretically span even across many pages is an unneeded code complication and amcheck is
nota tool that provides any warranty when checking an index. 

This confuses me a bit.  The regression test creates a table and index but never performs any DELETE nor any UPDATE
operations,so none of the index entries should be dead.  If I am understanding you correct, I'd be forced to conclude
thatthe uniqueness checking code is broken.  Can you take a look? 

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company






pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Comments on Custom RMGRs
Next
From: Nathan Bossart
Date:
Subject: Re: problems with "Shared Memory and Semaphores" section of docs