Re: Potential issue in ecpg-informix decimal converting functions - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Potential issue in ecpg-informix decimal converting functions
Date
Msg-id 28B21E92-1688-40A4-BD86-A31316A22F50@yesql.se
Whole thread Raw
In response to Re: Potential issue in ecpg-informix decimal converting functions  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Potential issue in ecpg-informix decimal converting functions
List pgsql-hackers
> On 27 Feb 2024, at 06:08, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Mon, Feb 26, 2024 at 12:28:51AM +0100, Daniel Gustafsson wrote:
>> Yeah, I think this is for HEAD only, especially given the lack of complaints
>> against backbranches.
>
> Daniel, are you planning to look at that?  I haven't done any detailed
> lookup, but would be happy to do so it that helps.

I had a look at this today and opted for trimming back the patch a bit.
Reading the informix docs the functions we are mimicking for compatibility here
does not have an underflow returnvalue, so adding one doesn't seem right (or
helpful).  The attached fixes the return of overflow and leaves it at that,
which makes it possible to backpatch since it's fixing the code to match the
documented behavior.

--
Daniel Gustafsson


Attachment

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: [PoC] Reducing planning time when tables have many partitions
Next
From: Tomas Vondra
Date:
Subject: Re: remaining sql/json patches