NULL handling in exconfig deconstruction - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject NULL handling in exconfig deconstruction
Date
Msg-id 289FFB8B-7AAB-48B5-A497-6E0D41D7BA47@yesql.se
Whole thread Raw
Responses Re: NULL handling in exconfig deconstruction
List pgsql-hackers
In extension_config_remove() we first ensure that pg_extension.extconfig cannot
contain any NULL values in the array, ERRORing out if so.  Later we however ask
for NULL values back when deconstructing the array, throwing away the results
knowing there wont be any, which seems superfluous (and wrong if there indeed
were any).  The attached patch signals to deconstruct_array() that any NULL
values should be considered an error instead of returned, to keep NULL value
handling consistent (and shave two small allocations off).

cheers ./daniel


Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: New vacuum option to do only freezing
Next
From: Alvaro Herrera
Date:
Subject: Re: move PartitionBoundInfo creation code