Re: fix for windows breakage in regression script - Mailing list pgsql-patches

From Tom Lane
Subject Re: fix for windows breakage in regression script
Date
Msg-id 28847.1105761917@sss.pgh.pa.us
Whole thread Raw
In response to Re: fix for windows breakage in regression script  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: fix for windows breakage in regression script
List pgsql-patches
Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> What about the Cygwin port --- will it have the same issue?  If so what
>> should we add?

> No, Cygwin works OK - still have occasional issues with non-empty
> tablespaces, but not this issue. The Cygwin environment itself emulates
> unix sockets, I think that's the reason.

Hm --- have you checked it since I changed the script?

port/cygwin.h claims that older versions of Cygwin don't have Unix
sockets, and there's a hack in pg_config_manual.h that sure looks like
it will disable HAVE_UNIX_SOCKETS on any Cygwin version.  I'm inclined
to think that pg_regress should play it safe and assume no Unix sockets
on Cygwin.

            regards, tom lane

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: dllist.c 0 -> NULL
Next
From: Andrew Dunstan
Date:
Subject: Re: fix for windows breakage in regression script