Re: [PATCHES] Fix "database is ready" race condition - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Fix "database is ready" race condition
Date
Msg-id 28827.1170685196@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Fix "database is ready" race condition  ("Simon Riggs" <simon@2ndquadrant.com>)
Responses Re: [PATCHES] Fix "database is ready" race condition  (Jim Nasby <decibel@decibel.org>)
List pgsql-hackers
"Simon Riggs" <simon@2ndquadrant.com> writes:
> My suggestions would be
> 1. "Database system has completed recovery" and
> 2. "Database system is ready to accept connections"

The second was in fact the wording I had in mind, sorry for not being
clear.  As to the first, the question is whether a log message at that
specific point has any use.  It's not "completion of recovery", exactly,
since we go through that spot whether it's a normal startup or recovery
(and there is another log message when we actually do any WAL replay).
AFAICS it's a fairly randomly chosen place in a long sequence of Things
That Must Happen.  Part of the reason Markus is seeing a race condition
is that this isn't the last thing done before the startup subprocess
exits --- see BootstrapMain.  So I'm for just getting rid of it.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Simon Riggs"
Date:
Subject: Re: "Compacting" a relation
Next
From: Bruce Momjian
Date:
Subject: Re: VC2005 build and pthreads