Re: 42.2.3 regression in fn timestampadd(SQL_TSI_MINUTE) - Mailing list pgsql-jdbc

From Adam Rauch
Subject Re: 42.2.3 regression in fn timestampadd(SQL_TSI_MINUTE)
Date
Msg-id 2876ecac-f496-a014-a9ca-bccec77134de@labkey.com
Whole thread Raw
In response to Re: 42.2.3 regression in fn timestampadd(SQL_TSI_MINUTE)  (Vladimir Sitnikov <sitnikov.vladimir@gmail.com>)
List pgsql-jdbc
Vladimir, thanks for the prompt fix!

I've confirmed that 42.2.4 works correctly with our unit tests (which 
exercise timestampadd using all the standard constants)... i.e., fix 
looks great.

Minor issue: I believe there's a typo in the 42.2.3 known issues section 
of the changelogs (/CHANGELOG.md and 
/docs/_posts/2018-07-12-42.2.3-release.md): I think "SQL_TSI_MINUTE is 
treated as minute" should be "SQL_TSI_MINUTE is treated as second".

Thanks!
Adam

On 7/14/2018 3:06 AM, Vladimir Sitnikov wrote:
> Adam, thanks for the prompt report.
>
> Please feel free to review a suggested fix: 
> https://github.com/pgjdbc/pgjdbc/pull/1250
>
> Vladimir



pgsql-jdbc by date:

Previous
From: Vladimir Sitnikov
Date:
Subject: [pgjdbc/pgjdbc] b1507f: docs: escape underscores in changelogotherwise it...
Next
From: Vladimir Sitnikov
Date:
Subject: [pgjdbc/pgjdbc] 5898cd: docs: typo in 42.2.3 changelog"minute->second"