Re: pgsql: Move gramparse.h to src/backend/parser - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Move gramparse.h to src/backend/parser
Date
Msg-id 2862807.1663184226@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Move gramparse.h to src/backend/parser  (John Naylor <john.naylor@postgresql.org>)
Responses Re: pgsql: Move gramparse.h to src/backend/parser  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
John Naylor <john.naylor@postgresql.org> writes:
> Move gramparse.h to src/backend/parser

The cfbot is unhappy since this commit; some but not all tests fail with

[09:33:13.793] In file included from scan.c:39:
[09:33:13.793] ./gramparse.h:29:10: fatal error: 'gram.h' file not found
[09:33:13.794] #include "gram.h"
[09:33:13.794]          ^~~~~~~~
[09:33:13.839] In file included from parser.c:25:
[09:33:13.839] ./gramparse.h:29:10: fatal error: 'gram.h' file not found
[09:33:13.839] #include "gram.h"
[09:33:13.839]          ^~~~~~~~

What I think is happening is that it was a mistake to remove
parser/gram.h from the dependencies of backend/Makefile's
generated-headers target: that allows builds to proceed before
gram.h has necessarily been created.  The fact that it works
at all for anybody says that there's another dependency path
somewhere that causes bison to get run ... but, seemingly,
that doesn't always happen soon enough in a parallel build.

            regards, tom lane



pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Use SIGNAL_ARGS consistently to declare signal handlers.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Update .gitignore