Re: miniscule compiler barf in pg_ctl.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: miniscule compiler barf in pg_ctl.c
Date
Msg-id 28619.1090460774@sss.pgh.pa.us
Whole thread Raw
In response to miniscule compiler barf in pg_ctl.c  ("Dann Corbit" <DCorbit@connx.com>)
List pgsql-hackers
"Dann Corbit" <DCorbit@connx.com> writes:
>   default:
>     ;  /* <<<<<<<<<< Just a semicolon added here <<<<<<<<<<<< */
>    /* assert(false); */
>  }

Personally I prefer writing
default:    break;

Switch branches that don't have break or return at the end are trouble
waiting to happen, compiler glitches or no ...

Patched, thanks!
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Missing header in zic.c?
Next
From: Christopher Kings-Lynne
Date:
Subject: Re: Why we really need timelines *now* in PITR