Re: [PATCH] Native spinlock support on RISC-V - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] Native spinlock support on RISC-V
Date
Msg-id 285263d1-b9f7-4342-a1f8-09176b923b1d@www.fastmail.com
Whole thread Raw
In response to Re: [PATCH] Native spinlock support on RISC-V  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Native spinlock support on RISC-V  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On Fri, Aug 13, 2021, at 19:25, Tom Lane wrote:
> I wrote:
> > Andres Freund <andres@anarazel.de> writes:
> >> Should we backpatch this? It's not like we're going to break existing
> >> risc-v systems by enabling spinlock support...
> 
> > Yeah, why not?  If you were building with --disable-spinlocks before,
> > this shouldn't change anything for you.
> > (I haven't actually looked at the patch, mind you, but in principle
> > it shouldn't break anything that worked before.)
> 
> I now have looked at the patch, and it seems good as far as it goes,
> but I wonder whether some effort ought to be expended in
> src/include/port/atomics/.

That should automatically pick up the intrinsic. I think we should do the same on modern compilers for spinlocks, but
that'sa separate discussion I guess.
 

Address



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Native spinlock support on RISC-V
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Native spinlock support on RISC-V