Re: [HACKERS] compiler warning with VS 2017 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] compiler warning with VS 2017
Date
Msg-id 28486.1494002827@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] compiler warning with VS 2017  (Petr Jelinek <petr.jelinek@2ndquadrant.com>)
List pgsql-hackers
Petr Jelinek <petr.jelinek@2ndquadrant.com> writes:
> On 05/05/17 16:56, Tom Lane wrote:
>> So the comment should be something like "if the column is unchanged,
>> we should not attempt to access its value beyond this point.  To
>> help catch any such attempts, set the string to NULL" ?

> Yes that sounds about right. We don't get any data for unchanged TOAST
> columns (that's limitation of logical decoding) so we better not touch them.

OK.  I just made it say "we don't get the value of unchanged columns".
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] what's up with IDENTIFIER_LOOKUP_EXPR?
Next
From: Petr Jelinek
Date:
Subject: Re: [HACKERS] logical replication syntax (was DROP SUBSCRIPTION,query cancellations and slot handling)