Postgres Pro
Downloads
Home   >   mailing lists

Re: [Patch] Fix enum type mismatch - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [Patch] Fix enum type mismatch
Date
Msg-id 28346.1258155906@sss.pgh.pa.us
Whole thread Raw
In response to [Patch] Fix enum type mismatch  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
List pgsql-hackers
Tree view 
Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
> Attached patch fixed following warning:
> "../../../src/include/nodes/parsenodes.h", line 487: warning: enumerator
> value overflows INT_MAX (2147483647)

> The reason is clear, enum is int not unsigned.

I think the compiler is entitled to assume either, actually.
But your fix is good either way.  Applied.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: I need to code a float with magnitude (ie unit of measure)
Next
From: Andrew Gierth
Date:
Subject: Aggregate ORDER BY docs patch, first attempt