Re: Pg18 Recursive Crash - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Pg18 Recursive Crash
Date
Msg-id 2830028.1734563400@sss.pgh.pa.us
Whole thread Raw
In response to Pg18 Recursive Crash  (Paul Ramsey <pramsey@cleverelephant.ca>)
Responses Re: Pg18 Recursive Crash
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> On Wed, 18 Dec 2024 at 23:45, David Rowley <dgrowleyml@gmail.com> wrote:
>> Maybe we need to backpatch passing NULL instead of &TTSOpsMinimalTuple
>> to ExecBuildGroupingEqual() in BuildTupleHashTableExt(). Something
>> like the attached patch.

> I've attached a more formal patch for this and I've also now done a
> bit more research and experimentation as to why we didn't notice this
> for so long.

I suspect that another key reason for the lack of reports is that
it's an assertion failure only, with no consequences in production
builds.  So ordinary users issuing such a query wouldn't notice.

> I propose to quickly do a master-only follow-up commit to use the
> inputOps instead of NULL in BuildTupleHashTableExt (Basically Tom's
> patch from [1])

LGTM.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Regression tests fail on OpenBSD due to low semmns value
Next
From: Melanie Plageman
Date:
Subject: Re: Can rs_cindex be < 0 for bitmap heap scans?