Re: Proposed patch for sequence-renaming problems - Mailing list pgsql-patches

From Tom Lane
Subject Re: Proposed patch for sequence-renaming problems
Date
Msg-id 28112.1128200511@sss.pgh.pa.us
Whole thread Raw
In response to Proposed patch for sequence-renaming problems  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Proposed patch for sequence-renaming problems  (Michael Paesold <mpaesold@gmx.at>)
List pgsql-patches
Here's an updated version of the patch.  There's now just one nextval()
function, taking regclass, and backwards compatibility is handled
through an implicit text-to-regclass cast.  Existing dumps will not see
any behavioral changes because nextval('foo') will be dumped as
nextval('foo'::text), but new entries of "nextval('foo')" will be
captured as regclass constants instead.

I noted that this version caused a couple more regression tests to fail;
for instance, the constraints test was expecting that it could drop and
recreate a sequence that was referenced by a default expression spelled
as "nextval('foo')".  So we are paying for improved ease of use by
taking a larger backwards-compatibility risk than the original patch
did.

Last call for objections ...

            regards, tom lane


Attachment

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Making pgxs builds work with a relocated installation
Next
From: Thomas Hallgren
Date:
Subject: Path to enable a module to change the stack_base_ptr