Re: [HACKERS] Patch: add --if-exists to pg_recvlogical - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [HACKERS] Patch: add --if-exists to pg_recvlogical
Date
Msg-id 27F24BA7-3DE7-4A9D-87F8-F7962691CBD7@yesql.se
Whole thread Raw
In response to Re: [HACKERS] Patch: add --if-exists to pg_recvlogical  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: [HACKERS] Patch: add --if-exists to pg_recvlogical
List pgsql-hackers
> On 09 Sep 2017, at 06:05, Thomas Munro <thomas.munro@enterprisedb.com> wrote:
>
> On Sat, Sep 2, 2017 at 5:22 AM, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>>      <varlistentry>
>> +      <term><option>--if-exists</option></term>
>> +      <listitem>
>> +       <para>
>> +        Do not error out when <option>--drop-slot</option> or
>> <option>--start<option> are
>> +        specified and a slot with the specified name does not exist.
>> +       </para>
>> +      </listitem>
>> +     </varlistentry>
>>
>> I understand the --drop-slot part.  But I don't understand what it means
>> to ignore a missing replication slot when running --start.
>
> Also "<option>--start<option>" breaks the documentation build (missing
> slash on the closing tag).

This patch is "Waiting for Author” due to the above review comments from Peter
and Thomas.  Do you think you will have time to address these shortly so we can
move this patch further in the process?

cheers ./daniel

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: [HACKERS] Partition-wise join for join between (declaratively)partitioned tables
Next
From: Thom Brown
Date:
Subject: Re: [HACKERS] SendRowDescriptionMessage() is slow for queries with alot of columns