Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCHES] COPY when 'filename' is a directory - Mailing list pgsql-bugs

From Tom Lane
Subject Re: [PATCHES] COPY when 'filename' is a directory
Date
Msg-id 27929.1014516663@sss.pgh.pa.us
Whole thread Raw
In response to Re: COPY when 'filename' is a directory  (Brent Verner <brent@rcfile.org>)
Responses Re: [PATCHES] COPY when 'filename' is a directory  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-bugs
Tree view 
Brent Verner <brent@rcfile.org> writes:
> | This coding is WRONG.  You do not use fclose() to release a file
> | opened with AllocateFile.

>   s/fclose/FreeFile/

Actually, my recommendation is to remove it altogether.  The mechanisms
are in place to close allocated files after elog(), so why waste thought
and code space to release them manually?

            regards, tom lane

pgsql-bugs by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] COPY when 'filename' is a directory
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] COPY when 'filename' is a directory