Re: [BUGS] COPY when 'filename' is a directory - Mailing list pgsql-patches

From Brent Verner
Subject Re: [BUGS] COPY when 'filename' is a directory
Date
Msg-id 20020224015622.GA22891@rcfile.org
Whole thread Raw
In response to Re: [BUGS] COPY when 'filename' is a directory  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [BUGS] COPY when 'filename' is a directory  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
[2002-02-23 20:27] Tom Lane said:
| Bruce Momjian <pgman@candle.pha.pa.us> writes:
| >           {
| > +       struct stat st;
| >               fp = AllocateFile(filename, PG_BINARY_R);

| > +         fclose(fp);
|
| This coding is WRONG.  You do not use fclose() to release a file
| opened with AllocateFile.

  s/fclose/FreeFile/

hiding in shame,
  brent

--
"Develop your talent, man, and leave the world something. Records are
really gifts from people. To think that an artist would love you enough
to share his music with anyone is a beautiful thing."  -- Duane Allman

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [BUGS] COPY when 'filename' is a directory
Next
From: Brent Verner
Date:
Subject: Re: [BUGS] COPY when 'filename' is a directory