Re: [BUGS] COPY when 'filename' is a directory - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [BUGS] COPY when 'filename' is a directory
Date
Msg-id 200202240203.g1O23Z100564@candle.pha.pa.us
Whole thread Raw
In response to Re: [BUGS] COPY when 'filename' is a directory  (Brent Verner <brent@rcfile.org>)
List pgsql-patches
Brent Verner wrote:
> [2002-02-23 20:27] Tom Lane said:
> | Bruce Momjian <pgman@candle.pha.pa.us> writes:
> | >           {
> | > +       struct stat st;
> | >               fp = AllocateFile(filename, PG_BINARY_R);
>
> | > +         fclose(fp);
> |
> | This coding is WRONG.  You do not use fclose() to release a file
> | opened with AllocateFile.
>
> corrected diff attached.

You are going to feel even more ashamed when you realize you sent a
non-context diff.  :-)

I can't apply that.  I need diff -c.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Brent Verner
Date:
Subject: Re: [BUGS] COPY when 'filename' is a directory
Next
From: Tom Lane
Date:
Subject: Re: [BUGS] COPY when 'filename' is a directory