Re: errno clobbering in reorderbuffer - Mailing list pgsql-hackers

From Tom Lane
Subject Re: errno clobbering in reorderbuffer
Date
Msg-id 27916.1471558645@sss.pgh.pa.us
Whole thread Raw
In response to errno clobbering in reorderbuffer  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> While researching a customer issue with BDR I noticed that one ereport()
> call happens after clobbering errno, leading to the wrong strerror being
> reported.  This patch fixes it by saving before calling
> CloseTransientFile and restoring afterwards.

> I also threw in a missing errcode I noticed while looking for similar
> problems in the same file.

Looks sane to me.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: errno clobbering in reorderbuffer
Next
From: Andres Freund
Date:
Subject: Re: errno clobbering in reorderbuffer