Re: errno clobbering in reorderbuffer - Mailing list pgsql-hackers

Hi,

On 2016-08-18 19:06:02 -0300, Alvaro Herrera wrote:
>      if (write(fd, rb->outbuf, ondisk->size) != ondisk->size)
>      {
> +        int save_errno = errno;
> +
>          CloseTransientFile(fd);
> +        errno = save_errno;
>          ereport(ERROR,
>                  (errcode_for_file_access(),
>                   errmsg("could not write to data file for XID %u: %m",

Independent of this specific case I kinda wish we had a better way to
deal with exactly this pattern. I even wonder whether having a close
variant not clobbering errno might be worthwhile.