Postgres Pro
Downloads
Home   >   mailing lists

Re: errno clobbering in reorderbuffer - Mailing list pgsql-hackers

From Andres Freund
Subject Re: errno clobbering in reorderbuffer
Date
Msg-id 20160818221200.md6vnxvhzll2qp53@alap3.anarazel.de
Whole thread Raw
In response to errno clobbering in reorderbuffer  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: errno clobbering in reorderbuffer  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On 2016-08-18 19:06:02 -0300, Alvaro Herrera wrote:
> While researching a customer issue with BDR I noticed that one ereport()
> call happens after clobbering errno, leading to the wrong strerror being
> reported.  This patch fixes it by saving before calling
> CloseTransientFile and restoring afterwards.
> 
> I also threw in a missing errcode I noticed while looking for similar
> problems in the same file.
> 
> This is to backpatch to 9.4.

Makes sense - you're doing that or shall I?

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: drop src/backend/port/darwin/system.c ?
Next
From: Tom Lane
Date:
Subject: Re: errno clobbering in reorderbuffer