Re: errno clobbering in reorderbuffer - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: errno clobbering in reorderbuffer
Date
Msg-id 20160819022103.GA985423@alvherre.pgsql
Whole thread Raw
In response to Re: errno clobbering in reorderbuffer  (Andres Freund <andres@anarazel.de>)
Responses Re: errno clobbering in reorderbuffer  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund wrote:
> On 2016-08-18 19:06:02 -0300, Alvaro Herrera wrote:
> > While researching a customer issue with BDR I noticed that one ereport()
> > call happens after clobbering errno, leading to the wrong strerror being
> > reported.  This patch fixes it by saving before calling
> > CloseTransientFile and restoring afterwards.
> > 
> > I also threw in a missing errcode I noticed while looking for similar
> > problems in the same file.
> > 
> > This is to backpatch to 9.4.
> 
> Makes sense - you're doing that or shall I?

I am, if you don't mind.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Missing checks when malloc returns NULL...
Next
From: Andres Freund
Date:
Subject: Re: errno clobbering in reorderbuffer