Re: [HACKERS] path toward faster partition pruning - Mailing list pgsql-hackers

From Amit Langote
Subject Re: [HACKERS] path toward faster partition pruning
Date
Msg-id 278abb39-d784-bc18-c8cc-c42e3e1e89d1@lab.ntt.co.jp
Whole thread Raw
In response to Re: [HACKERS] path toward faster partition pruning  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
On 2018/03/20 21:41, David Rowley wrote:
> On 21 March 2018 at 00:07, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> Attached is further revised version.
> 
> In the 0004 patch I see:
> 
> @@ -1439,6 +1441,10 @@ inheritance_planner(PlannerInfo *root)
>   if (IS_DUMMY_PATH(subpath))
>   continue;
> 
> + /* Add the current parent's RT index to the partitioned rels set. */
> + partitioned_relids = bms_add_member(partitioned_relids,
> + appinfo->parent_relid);
> 
> This seems to execute regardless of if the target relation is a
> partitioned table or an inheritance parent. I think there needs to be
> a condition so you only do this when planning for partitioned tables.

Oops, that's quite wrong.  Will fix, thanks.

Regards,
Amit



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: faster testing with symlink installs
Next
From: Pavan Deolasee
Date:
Subject: Re: ON CONFLICT DO UPDATE for partitioned tables