Re: Include tablespace information in psql \d footers - Mailing list pgsql-patches

From Tom Lane
Subject Re: Include tablespace information in psql \d footers
Date
Msg-id 2780.1088201577@sss.pgh.pa.us
Whole thread Raw
In response to Include tablespace information in psql \d footers  (Gavin Sherry <swm@linuxworld.com.au>)
Responses Re: Include tablespace information in psql \d footers  (Gavin Sherry <swm@linuxworld.com.au>)
List pgsql-patches
Gavin Sherry <swm@linuxworld.com.au> writes:
> Attached.

Couple of problems with this:

1. Don't #ifndef WIN32 it.  In the first place, we might have tablespace
support on Windows later, and in the second place, even if psql is
running on Windows that doesn't mean the server it's talking to is.

2. Printing "pg_default" when reltblspace is zero is wrong.  Get the
database's default tablespace and print that.  Or perhaps better,
don't print anything at all; that would avoid cluttering the display
for people who don't use tablespaces.

            regards, tom lane

pgsql-patches by date:

Previous
From: Simon Riggs
Date:
Subject: Re: tz error prevents postmaster.c compiling...
Next
From: Alvaro Herrera
Date:
Subject: Re: nested xacts and phantom Xids