Re: Use C99 designated initializers for some structs - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Use C99 designated initializers for some structs
Date
Msg-id 27632.1535666005@sss.pgh.pa.us
Whole thread Raw
In response to Re: Use C99 designated initializers for some structs  (Mark Dilger <hornschnorter@gmail.com>)
List pgsql-hackers
Mark Dilger <hornschnorter@gmail.com> writes:
> I tried doing this perhaps a year ago, and there are a few files with arrays
> of structs whose representations get much larger when you change the format
> in this way.  For instance, in guc.c:
> ...
> What should the general rule be for initializing arrays of structs such as these?

I'd argue that there is no reason to convert initializers except where
it's a clear notational win.  If it isn't, leaving things alone will
be less of a maintenance problem.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_verify_checksums and -fno-strict-aliasing
Next
From: Justin Pryzby
Date:
Subject: Re: 10.5 but not 10.4: backend startup during reindex system: couldnot read block 0 in file "base/16400/..": read only 0 of 8192 bytes