Re: code cleanup for SearchSysCache - Mailing list pgsql-hackers

From Tom Lane
Subject Re: code cleanup for SearchSysCache
Date
Msg-id 27600.1149778861@sss.pgh.pa.us
Whole thread Raw
In response to code cleanup for SearchSysCache  ("Qingqing Zhou" <zhouqq@cs.toronto.edu>)
List pgsql-hackers
"Qingqing Zhou" <zhouqq@cs.toronto.edu> writes:
> There are roughly 420 calls of SearchSysCache() and 217 of which are just
> report "cache lookup failed". Shall we put the elog in the SearchSysCache
> itself?

You'd need two essentially equivalent versions of SearchSysCache, and
you'd lose the ability to make the error message identify what was being
searched for, so I vote no.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Joshua D. Drake"
Date:
Subject: Re: How to avoid transaction ID wrap
Next
From: Greg Stark
Date:
Subject: Re: ADD/DROP INHERITS