code cleanup for SearchSysCache - Mailing list pgsql-hackers

From Qingqing Zhou
Subject code cleanup for SearchSysCache
Date
Msg-id e68bjv$i87$1@news.hub.org
Whole thread Raw
Responses Re: code cleanup for SearchSysCache  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
There are roughly 420 calls of SearchSysCache() and 217 of which are just
report "cache lookup failed". Shall we put the elog in the SearchSysCache
itself?

Notice that most search is on the "Oid" field -- which is *not* user
visible, so I think most of them can safely let SearchSysCache handle the
failed search without reporting any misleading information. Also, to support
situations where indeed need to check the return tuple, we can add a boolean
parameter "isComplain" to the argument list.

Regards,
Qingqing




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: ADD/DROP INHERITS
Next
From: Koichi Suzuki
Date:
Subject: Re: How to avoid transaction ID wrap