Re: proposal - assign result of query to psql variable - Mailing list pgsql-hackers

From Tom Lane
Subject Re: proposal - assign result of query to psql variable
Date
Msg-id 27593.1351175895@sss.pgh.pa.us
Whole thread Raw
In response to Re: proposal - assign result of query to psql variable  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: proposal - assign result of query to psql variable  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: proposal - assign result of query to psql variable  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> I gave this a look.  I think it needs to be revised by somebody with a
> better understanding of scanner (flex) than me, but I didn't like the
> changes in psqlscan.l at all; the new <xvl> pattern is too unlike the
> rest of the surrounding patterns, and furthermore it has been placed
> within the block that says it mirrors the backend scanner, when it
> obviously has no equivalent there.

> I assume there's a better way to do this.  Hints would be appreciated.

Personally I saw no reason for this patch to touch psqlscan.l in the
first place.  Commands such as \set just scan variable names with
psql_scan_slash_option(OT_NORMAL); why shouldn't this act the same?

Moreover, the proposed lexer rules are flat out *wrong*, in that they
insist on the target variable names being {identifier}s, a restriction
not imposed by \set.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: proposal - assign result of query to psql variable
Next
From: Alvaro Herrera
Date:
Subject: Re: proposal - assign result of query to psql variable