Re: [PATCH] Add SIGCHLD catch to psql - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Add SIGCHLD catch to psql
Date
Msg-id 2759.1274026953@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Add SIGCHLD catch to psql  (Stephen Frost <sfrost@snowman.net>)
Responses Re: [PATCH] Add SIGCHLD catch to psql
List pgsql-hackers
Stephen Frost <sfrost@snowman.net> writes:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>> A saner
>> approach, which would also help for other corner cases such as
>> out-of-disk-space, would be to check for write failures on the output
>> file and abandon the query if any occur.

> I had considered this, but I'm not sure we really need to catch *every*
> write failure.  Perhaps just catching if the '\n' at the end of a row
> fails to be written out would be sufficient?

If you're combining this with the FETCH_COUNT logic then it seems like
it'd be sufficient to check ferror(fout) once per fetch chunk, and just
fall out of that loop then.  I don't want psql issuing query cancels
on its own authority, either.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Keepalive for max_standby_delay
Next
From: Robert Haas
Date:
Subject: Re: Performance problem in textanycat/anytextcat