Re: [PATCH] Add TOAST support for several system tables - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Add TOAST support for several system tables
Date
Msg-id 2748770.1646089728@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] Add TOAST support for several system tables  (Sofia Kopikova <s.kopikova@postgrespro.ru>)
Responses Re: [PATCH] Add TOAST support for several system tables
List pgsql-hackers
=?UTF-8?B?U29maWEgS29waWtvdmE=?= <s.kopikova@postgrespro.ru> writes:
> ACL lists in tables may potentially be large in size. I suggest adding TOAST support for system tables, namely
pg_class,pg_attribute and pg_largeobject_metadata, for they include ACL columns. 

TBH, the idea of adding a toast table to pg_class scares the daylights
out of me.  I do not for one minute believe that you've fixed every
problem that will cause, nor do I think "allow wider ACLs" is a
compelling enough reason to take the risk.

I wonder if it'd be practical to move the ACLs for relations
and attributes into some new table, indexed like pg_depend or
pg_description, so that we could dodge that whole problem.
pg_attrdef is a prototype for how this could work.

(Obviously, once we had such a table the ACLs for other things
could be put in it, but I'm not sure that the ensuing breakage
would be justified for other sorts of objects.)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: MSVC build system installs extra executables
Next
From: Tom Lane
Date:
Subject: Overflow of attmissingval is not handled gracefully