Re: Question regarding SSL code in backend and frontend - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Question regarding SSL code in backend and frontend
Date
Msg-id 27393.1333555030@sss.pgh.pa.us
Whole thread Raw
In response to Question regarding SSL code in backend and frontend  (Tatsuo Ishii <ishii@postgresql.org>)
Responses Re: Question regarding SSL code in backend and frontend  (Magnus Hagander <magnus@hagander.net>)
Re: Question regarding SSL code in backend and frontend  (Tatsuo Ishii <ishii@postgresql.org>)
List pgsql-hackers
Tatsuo Ishii <ishii@postgresql.org> writes:
> Those code fragment judges the return value from
> SSL_read(). secure_read() does retrying when SSL_ERROR_WANT_READ *and*
> SSL_ERROR_WANT_WRITE returned. However, pqsecure_read() does not retry
> when SSL_ERROR_WANT_READ. It seems they are not consistent. Comments?

There's no particular reason why they should be consistent, I think.
The assumptions for nonblocking operation are different.

I rather wonder whether the #ifdef WIN32 bit in the backend isn't dead
code though.  If the port isn't in nonblock mode, we shouldn't really
get here at all, should we?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Boszormenyi Zoltan
Date:
Subject: Re: [PATCH] lock_timeout and common SIGALRM framework
Next
From: Magnus Hagander
Date:
Subject: Re: Question regarding SSL code in backend and frontend