Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Fix bug leading to restoring unlogged relations from empty files - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix bug leading to restoring unlogged relations from empty files
Date
Msg-id 27390.1450028238@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Fix bug leading to restoring unlogged relations from empty files  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: Fix bug leading to restoring unlogged relations from empty files  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Tree view 
Andres Freund <andres@anarazel.de> writes:
> Fix bug leading to restoring unlogged relations from empty files.

Coverity thinks, quite correctly AFAICS, that this line you wrote in
FlushOneBuffer() is useless:

    LWLockHeldByMe(bufHdr->content_lock);

Perhaps you meant

    Assert(LWLockHeldByMe(bufHdr->content_lock));

?

            regards, tom lane

pgsql-committers by date:

Previous
From: Magnus Hagander
Date:
Subject: pgsql: Properly initialize write, flush and replay locations in walsend
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Fix bug leading to restoring unlogged relations from empty files