Re: [COMMITTERS] pgsql: Add support for temporary replication slots - Mailing list pgsql-committers

Peter Eisentraut <peter_e@gmx.net> writes:
> Add support for temporary replication slots

Some of the slower buildfarm members are failing test-decoding-check since
this went in.  At least on prairiedog, it looks like a race condition in
the test:

** /Users/buildfarm/bf-data/HEAD/pgsql.build/contrib/test_decoding/expected/slot.out    Mon Dec 12 09:24:32 2016
--- /Users/buildfarm/bf-data/HEAD/pgsql.build/contrib/test_decoding/./regression_output/results/slot.out    Mon Dec 12
10:01:312016 
***************
*** 32,38 ****

  -- should fail because the temporary slot was dropped automatically
  SELECT pg_drop_replication_slot('regression_slot_t');
! ERROR:  replication slot "regression_slot_t" does not exist
  -- test switching between slots in a session
  SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot1', 'test_decoding', true);
   ?column?
--- 32,38 ----

  -- should fail because the temporary slot was dropped automatically
  SELECT pg_drop_replication_slot('regression_slot_t');
! ERROR:  replication slot "regression_slot_t" is active for PID 17615
  -- test switching between slots in a session
  SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot1', 'test_decoding', true);
   ?column?

            regards, tom lane