Re: pgsql: Unbreak the build. - Mailing list pgsql-committers

Andres Freund <andres@anarazel.de> writes:
> And windows still fails tests after this commit: https://cirrus-ci.com/task/6424123323711488?logs=test_bin#L22

Yeah.  drongo is reporting

# Running: pg_basebackup --no-sync -cfast -D
C:\\prog\\bf\\root\\HEAD\\pgsql.build\\src\\bin\\pg_basebackup\\tmp_check\\tmp_test_vv4i/tarbackup-Ft 
Assertion failed: 0, file c:\\prog\\bf\\root\\HEAD\\pgsql.build\\src\\bin\\pg_basebackup\\walmethods.c, line 953
not ok 82 - tar format

#   Failed test 'tar format'
#   at t/010_pg_basebackup.pl line 261.

which is pointing at

        /* not reachable */
        Assert(false);

so it's not so unreachable after all.

            regards, tom lane