Re: SKIP LOCKED DATA (work in progress) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: SKIP LOCKED DATA (work in progress)
Date
Msg-id 27211.1406385781@sss.pgh.pa.us
Whole thread Raw
In response to Re: SKIP LOCKED DATA (work in progress)  (Thomas Munro <munro@ip9.org>)
Responses Re: SKIP LOCKED DATA (work in progress)  (Thomas Munro <munro@ip9.org>)
Re: SKIP LOCKED DATA (work in progress)  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Thomas Munro <munro@ip9.org> writes:
> I couldn't find an existing reasonable place to share a single wait
> policy enumeration between parser/planner/executor and the heap access
> module, and I get the feeling that it would be unacceptable to
> introduce one.

There is a precedent in the form of AclMode, which is needed throughout
the system and is currently declared in parsenodes.h.  I can't say I've
ever been particularly pleased with that arrangement though, since it
forces inclusion of parsenodes.h in many places that might not otherwise
have any interest in parse nodes.

It might be better if we'd declared AclMode in a single-purpose header,
say utils/aclmode.h, and then #include'd that into parsenodes.h.
There's certainly plenty of other single-datatype headers laying about.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: get_loop_count() fails to ignore RELOPT_DEADREL rels
Next
From: Guillaume Lelarge
Date:
Subject: config.sgml referring to unix_socket_directories on older releases