Re: Minor BEFORE DELETE trigger fix - Mailing list pgsql-patches

From Tom Lane
Subject Re: Minor BEFORE DELETE trigger fix
Date
Msg-id 27186.1091862203@sss.pgh.pa.us
Whole thread Raw
In response to Re: Minor BEFORE DELETE trigger fix  (Gavin Sherry <swm@linuxworld.com.au>)
List pgsql-patches
Gavin Sherry <swm@linuxworld.com.au> writes:
> Now, if for all the triggers on the base relation, !trigger->tgenabled is
> true, then newtuple will always be NULL.

Hmm ... seems like the all-triggers-disabled case should act the same as
the no-triggers-at-all case, which this doesn't seem to do.  It does
look broken but this doesn't seem like the correct fix.

>> Also, if there is a point, why are we changing only one of the
>> several ExecFOOTriggers functions?

> Because only BEFORE DELETE worries about trigger procedures returning
> NULL, from memory.

Do I have to do more than raise my eyebrow here?

            regards, tom lane

pgsql-patches by date:

Previous
From: Dennis Bjorklund
Date:
Subject: Re: [HACKERS] UNICODE characters above 0x10000
Next
From: Stefan Kaltenbrunner
Date:
Subject: psql - missing tab-completion support for tablespaces